Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

524 require questionnaire fields #51

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Conversation

avirgulto
Copy link
Contributor

@avirgulto avirgulto commented Oct 18, 2023

Describe your changes

Add in env variable for 'developer mode' which decides whether or not to show the 'ignore required fields' checkbox.
If

  • developer mode is true, show checkbox to enable users to check yes or no to ignore the required fields.
  • develop mode is false, checkbox is not showed, defaults to requiring required fields.

If required fields are required and there is a missing field, the submit button is disabled with a tooltip that says 'Fill out missing fields' and text under the button in red to show which fields need to be filled out. If required fields are required and there is not a missing field, the button is enabled with a tooltip saying 'submit to rems admin'.

To test:

  • test out with env variable set to true, which will show the checkbox. check/uncheck the checkbox to see the changes.
  • test out with env variable set to false, which won't show the checkbox option. It will require required fields on forms.

Issue ticket number and Jira link

https://jira.mitre.org/browse/REMS-524

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@avirgulto avirgulto merged commit 5af84ae into dev Oct 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants